|
Post by rioneru on Oct 20, 2017 7:10:24 GMT
wait its working on s6??? s6 is 2560x1440 and i thought this script only works on 1920x1080? ? ?
|
|
|
Post by wololo on Oct 20, 2017 7:56:57 GMT
wait its working on s6??? s6 is 2560x1440 and i thought this script only works on 1920x1080? ? ? It can work if you change this scriptDimension = 1920 Settings:setScriptDimension(true, scriptDimension) Settings:setCompareDimension(true, scriptDimension) to this in your case scriptDimension = 2560 Settings:setScriptDimension(true, 1920) <--- here needs to be 1920, as it is the resolution the script was made for Settings:setCompareDimension(true, scriptDimension) in the beginning of the script. But i cant help with errors as i dont have a device with that resolution. Also im not 100% if this works like i think. autoconfig , do you have any experience with compare dimension and other resolutions, and could confirm this? I might add an option to select your resolution, for the common resolutions used if it works like this.
|
|
|
Post by wololo on Oct 20, 2017 11:47:57 GMT
updated to 0.4.5, added resolution options
|
|
|
Post by autoconfig on Oct 20, 2017 18:50:22 GMT
wait its working on s6??? s6 is 2560x1440 and i thought this script only works on 1920x1080? ? ? It can work if you change this scriptDimension = 1920 Settings:setScriptDimension(true, scriptDimension) Settings:setCompareDimension(true, scriptDimension) to this in your case scriptDimension = 2560 Settings:setScriptDimension(true, 1920) <--- here needs to be 1920, as it is the resolution the script was made for Settings:setCompareDimension(true, scriptDimension) in the beginning of the script. But i cant help with errors as i dont have a device with that resolution. Also im not 100% if this works like i think. autoconfig , do you have any experience with compare dimension and other resolutions, and could confirm this? I might add an option to select your resolution, for the common resolutions used if it works like this. Unfortunately I do have experience with this. I beat my head against a brick wall for a few weeks trying to make a bot universal to any resolution. The above is correct. The value in setScriptDimension should be the width of the res the script was made for. The bot will then scale regions and locations based on that number compared to the device screen width. The value in setCompareDimension should be the current devices screen width. Using this the bot will scale the saved images to that size for image comparison. Keep in mind this method will *only* work if the running device is the same aspect ratio as the script itself. Both 2560x1440 and 1920x1080 are 16:9, so in theory the bot should scale correctly with the settings wololo mentioned on a 2560x1440 device. In theory... Something I learned the hard way is that Summoners War (and other games) will sometimes change the scale of their images based on the devices resolution, they aren't always perfectly stretched. Take for instance the battle map; on a 1920 device if I scroll all the way left I cannot see the Isle of Conquest at all. On my Note 8 (2792x1440) if I scroll all the way left I can see over half of the Isle of Conquest. Given the 2792 device has an 18.5:9 aspect ratio the images do not stretch perfectly, they only increase to a 2560x1440 size (limited by Y-axis) and this causes many things to be displaced on the X-axis. Because of this I realized making a universal resolution scaling would not be possible unless every device had an app-useable-screen-size that was a 16:9 ratio. The addition of soft-keys only complicates this more. Ultimately, if you're using a 2560x1440 device with no soft keys and the game takes up the whole screen, the scaling should work just fine with the code changes wololo stated.
|
|
|
Post by wololo on Oct 20, 2017 19:29:31 GMT
Thank you very much for the detailed explanation! So this will be trial and error which resolutions work perfectly, thats really sad. So to make this work i would need images for every resolution that has strange scaling from com2us's side.... Thats just too much work and i dont even can take images if i dont have a device with that resolution. I will keep the 16:9 ratio resolutions and nothing else in the hope it is working, if not i will get rid of the not working ones.
|
|
|
Post by wssn on Oct 23, 2017 4:58:12 GMT
|
|
|
Post by roivi22es on Oct 23, 2017 6:12:41 GMT
I have the same problem. (The Grade is set to "5* Hero", but it still collects 5* Rares. Although some of them still sells) I think the problem is the accuracy of the definition.
Also in the latest version of the bot again did not work "onscreen stats" The value "Rune" changes only in the next attack cycle, and all the time S=0 In the previous version worked well.
|
|
|
Post by wololo on Oct 23, 2017 7:47:42 GMT
I will look into the filter problem, but the rune gets detected right and the code seems right, i will test it with the same settings today.
Regarding the onscreen stats, i didnt touch any code. I dont know whats the problem.
edit: i found the problem why it kept rare runes, will provide a fix soon.
|
|
|
Post by wssn on Oct 23, 2017 9:18:00 GMT
I will look into the filter problem, but the rune gets detected right and the code seems right, i will test it with the same settings today. Regarding the onscreen stats, i didnt touch any code. I dont know whats the problem. edit: i found the problem why it kept rare runes, will provide a fix soon. thx u for your hard work waiting for the fix
|
|
|
Post by wololo on Oct 23, 2017 9:40:40 GMT
Updated to 0.4.6.
|
|
|
Post by wssn on Oct 23, 2017 10:16:54 GMT
Thx u , will test it now . Will u add arena refresh in the future ?
|
|
|
Post by wololo on Oct 23, 2017 11:16:57 GMT
Thx u , will test it now . Will u add arena refresh in the future ? Arena will be refreshed if you lose a fight to make sure you don't always fight the same guy and lose. Or what Do you mean by Arena refresh? Like filtering opponents by how many monsters there are or how many 6* monsters? If that was the question, it is planned after i got everything to work. Next major update will be raid farming.
|
|
|
Post by wssn on Oct 23, 2017 11:29:35 GMT
Thx u , will test it now . Will u add arena refresh in the future ? Arena will be refreshed if you lose a fight to make sure you don't always fight the same guy and lose. Or what Do you mean by Arena refresh? Like filtering opponents by how many monsters there are or how many 6* monsters? If that was the question, it is planned after i got everything to work. Next major update will be raid farming.no I mean arena wing refresh using crystal, no filter needed ex: arena only and with refresh wing choice box
|
|
|
Post by wololo on Oct 23, 2017 12:16:38 GMT
Now i get it. I never thought someone would want this in an automatic script, but this shouldn't be hard to inplement, might be in the next update.
|
|
|
Post by wssn on Oct 23, 2017 12:24:14 GMT
Now i get it. I never thought someone would want this in an automatic script, but this shouldn't be hard to inplement, might be in the next update. thx u , no script in the forum have that.
|
|